include field name in unsupported type error message #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ickymettle ! |
cihangir
pushed a commit
that referenced
this pull request
Sep 11, 2015
include field name in unsupported type error message
|
We eventually should add more supported types. There is also the issue #26 because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was retrofitting multiconfig into an existing project today and run up against a few unsupported types. I was finding that error messages such as:
This left me scratching my head on what field was failing (it was indirectly an int64, a time.Duration).
This patch adds the failing field name to the error message, which produces messages such as:
Thanks for a great library!